West Midlands | ITP-Sept-25 | Mustaf Asani | Sprint 2 | Book Library #363
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asaniDev
added
📅 Sprint 2
cjyuan
reviewed
Dec 17, 2025
Contributor
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
Can you check if any of this general feedback can help you further improve your code?
https://github.com/cjyuan/Module-Data-Flows/blob/book-library-feedback/debugging/book-library/feedback.md
Doing so can help me speed up the review process. Thanks.
cjyuan
added
Reviewed
…e missed, and fixed those errors.
asaniDev
added
the
Needs Review
cjyuan
reviewed
Dec 21, 2025
| delBut.innerHTML = "Delete"; | ||
| delBut.addEventListener("clicks", function () { | ||
| alert(`You've deleted title: ${myLibrary[i].title}`); | ||
| delButton.id = i + 5; |
Contributor
There was a problem hiding this comment.
- Lines 86, 104:
- Are the values assigned to these
idattributes unique? - Is there any need to assign an id attribute to either buttons?
- Are the values assigned to these
cjyuan
removed
the
Needs Review
…tor romved unnecessary id's
asaniDev
added
the
Needs Review
cjyuan
reviewed
Dec 22, 2025
| delBut.innerHTML = "Delete"; | ||
| delBut.addEventListener("clicks", function () { | ||
| alert(`You've deleted title: ${myLibrary[i].title}`); | ||
| delButton.id = i + 5; |
cjyuan
removed
the
Needs Review
Author
|
the emoji was just say its completed |
…esstring comparison
asaniDev
added
the
Needs Review
cjyuan
reviewed
Dec 22, 2025
Contributor
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
Changes look good.
I asked about the emoji because I didn't see any change based on my comments on the id attribute assigned to the buttons. Words are probably more precise than emoji.
cjyuan
added
Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Fixed all mentioned bugs as well as some that were not mentioned